Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): move workspace implementation to affine #9504

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone changed the title refactor(editor): move workspace implementation in affine refactor(editor): move workspace implementation to affine Jan 3, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Saul-Mirone Saul-Mirone changed the title refactor(editor): move workspace implementation to affine refactor(core): move workspace implementation to affine Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 1.61290% with 61 lines in your changes missing coverage. Please review.

Project coverage is 52.91%. Comparing base (897c7d4) to head (cfd64f1).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ntend/core/src/modules/workspace/impl/workspace.ts 1.72% 57 Missing ⚠️
...blocksuite/presets/_common/utils/markdown-utils.ts 0.00% 1 Missing ⚠️
.../blocksuite/presets/ai/messages/slides-renderer.ts 0.00% 1 Missing ⚠️
...cksuite/presets/ai/mini-mindmap/mindmap-preview.ts 0.00% 1 Missing ⚠️
...d/core/src/modules/workspace/entities/workspace.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9504      +/-   ##
==========================================
- Coverage   53.16%   52.91%   -0.25%     
==========================================
  Files        2151     2152       +1     
  Lines       96982    97039      +57     
  Branches    16189    16161      -28     
==========================================
- Hits        51561    51350     -211     
- Misses      44051    44322     +271     
+ Partials     1370     1367       -3     
Flag Coverage Δ
server-test 78.14% <ø> (-0.65%) ⬇️
unittest 32.50% <1.61%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone force-pushed the 01-03-refactor_editor_move_workspace_implementation_in_affine branch from 16098fc to 13e1893 Compare January 3, 2025 07:53
@Saul-Mirone Saul-Mirone marked this pull request as ready for review January 3, 2025 07:53
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner January 3, 2025 07:53
@Saul-Mirone Saul-Mirone force-pushed the 01-03-refactor_editor_move_workspace_implementation_in_affine branch from 13e1893 to 43e069d Compare January 3, 2025 08:00
Copy link

graphite-app bot commented Jan 3, 2025

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 01-03-refactor_editor_move_workspace_implementation_in_affine branch from 43e069d to cfd64f1 Compare January 3, 2025 08:14
@graphite-app graphite-app bot merged commit cfd64f1 into canary Jan 3, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-03-refactor_editor_move_workspace_implementation_in_affine branch January 3, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants